We should not throw NRE when converter not found.

[aensidhe]

[roman-kozachenko]

Exception is thrown in MsgPackSerializer.GetConverter. I think it is better to return null if MsgPackContext.GetConveter can't found converter.

[aensidhe]

Returning null will just move NRE to user code. We should throw special kind of exception, user can see them in logs.

On 01 Jul 2016, at 14:09 , roman-kozachenko notifications@github.com wrote:

Exception is thrown in MsgPackSerializer.GetConverter. I think it is better to return null if MsgPackContext.GetConveter can't found converter.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub #34 (comment), or mute the thread https://github.com/notifications/unsubscribe/ADw9-_Eso1XKPoubqX5gDRDhi-d5dbCyks5qRPV5gaJpZM4JCNK2.