Skip to content
This repository was archived by the owner on Sep 2, 2022. It is now read-only.

Conversation

@tianhuil
Copy link

@CLAassistant
Copy link

CLAassistant commented Jul 14, 2019

CLA assistant check
All committers have signed the CLA.

@tianhuil
Copy link
Author

@mavilein, @do4gr, @nikolasburk, @timsuchanek: any thoughts on merging this?

@mavilein
Copy link
Contributor

@tianhuil : Thanks for submitting this fix and also for pinging us! I will ask @timsuchanek to follow up who is our resident javascript expert.

@timsuchanek timsuchanek changed the base branch from master to alpha July 23, 2019 07:37
@timsuchanek timsuchanek changed the base branch from alpha to master July 23, 2019 07:37
@timsuchanek
Copy link
Contributor

Hi @tianhuil, thanks a lot for the PR! I just checked, the marked dependency is not in use anymore, the method it's defined in isn't used in our code.
So 2 asks:
Optimally you even remove that code in a PR.
In both cases: Please do the PR against the alpha branch.

@tianhuil
Copy link
Author

tianhuil commented Jul 31, 2019

@timsuchanek: thanks for the reply (sorry for the lateness, I don't check GitHub that often).

I don't think we can just remove the dependency (see below from the alpha branch) but I'm happy to redo this PR against the alpha branch.

$ git grep marked -- **.ts
cli/packages/prisma-cli-engine/src/Output/index.ts:import * as marked from 'marked'
cli/packages/prisma-cli-engine/src/Output/index.ts:import * as TerminalRenderer from 'marked-terminal'
cli/packages/prisma-cli-engine/src/Output/index.ts:marked.setOptions({
cli/packages/prisma-cli-engine/src/Output/index.ts:    this.log(marked(markdown))

@timsuchanek: needed to create this prisma/prisma#4777

Please close this PR when you merge the other one.

@tianhuil tianhuil changed the base branch from master to alpha July 31, 2019 23:19
@tianhuil tianhuil changed the base branch from alpha to master July 31, 2019 23:19
@tianhuil tianhuil mentioned this pull request Jul 31, 2019
@gustawdaniel
Copy link

Hey.

  • What need to be done to accept this pull request?
  • Is any person responsible for this?
  • How can I help?

@janpio janpio closed this Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants