fix icon-related dependencies in Windows makefile - #98
Merged
Conversation
ixfd64
changed the title
mfaktc.ico dependency
N-Storm
marked this pull request as draft
December 10, 2025 15:09
N-Storm
marked this pull request as ready for review
December 10, 2025 15:14
Member
|
Thanks for fixing the issue!
Because it runs make with |
N-Storm
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RC actually also requires
mfaktc.icoto generate themfaktc.resfile. While the original makefile somehow still worked in GitHub Actions, runningmake -f Makefile.winon a local machine resulted in an error aboutmfaktc.iconot being found. This PR fixes the Windows makefile to avoid this issue.