Use fontStack token in $body-font #2864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating $body-font variable to use --fontStack-sansSerif
🦋 Changeset detectedLatest commit: 66f3eb0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the $body-font Sass variable to leverage the new --fontStack-sansSerif CSS custom property while preserving the existing fallback font stack.
- Introduces
var(--fontStack-sansSerif, …fallback fonts…)in place of a hard-coded font list.
Comments suppressed due to low confidence (1)
src/support/variables/typography.scss:35
- [nitpick] Add a brief comment above this line explaining that
$body-fontnow sources from the--fontStack-sansSerifCSS custom property with fallbacks, so future maintainers understand its purpose.
$body-font: var(--fontStack-sansSerif, -apple-system, BlinkMacSystemFont, 'Segoe UI', 'Noto Sans', Helvetica, Arial, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji') !default;
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating $body-font variable to use
--fontStack-sansSerifWhat are you trying to accomplish?
Make sure that the primitives token
--fontStack-sansSerifis used for text on github via the$body-fontvariable.What approach did you choose and why?
Add
--fontStack-sansSeriftoken to the$body-fontvariable.What should reviewers focus on?
Can these changes ship as is?