Update slider.ts #16216
Merged
Update slider.ts #16216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing role attribute to second slider on range type slide to pass chrome lighthouse accessibility audit.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Closed
Contributor
|
Hi, Thanks a lot for the effort and support! |
Contributor
Author
Thanks for the quick response, I tried out the 17.18.9 version deployed to NPM after updating it locally and I can't see the slider role above in the package in \node_modules\primeng\esm2022\slider\slider.mjs file, but the markup doesn't seem to update and show the role="slider" on that second slider. I tried deleting the primeng package and re installing it to insure it was not cache issue with NPM. I wondering if I missed somewhere else that it need changed or it didn't fully update after build correctly. |
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16214
Add missing role attribute to second slider on range type slide to pass chrome lighthouse accessibility audit.
Reference for ticket details
Defect Fixes
When submitting a PR, please also create an issue documenting the error and manually link to an issue or mention it in the description using #<issue_id>.
Feature Requests
Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.
Smaller scaled feature implementations such as adding a property to a component will be considered for merging.