Skip to content

fixes #16020 Table: column-filter outside click does not close when it is inside a dialog component #16021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2024
Merged

fixes #16020 Table: column-filter outside click does not close when it is inside a dialog component #16021

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1df5b67
fixes #16020
codizen-dev Jul 13, 2024
33def4e
queried the date-picker class to fix the issue
codizen-dev Jul 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/components/table/table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5133,7 +5133,7 @@ export class ReorderableRow implements AfterViewInit {
[ngClass]="{ 'p-column-filter-overlay p-component p-fluid': true, 'p-column-filter-overlay-menu': display === 'menu' }"
[id]="overlayId"
[attr.aria-modal]="true"
role="dialog"
role="filterDialog"
(click)="onContentClick()"
[@overlayAnimation]="'visible'"
(@overlayAnimation.start)="onOverlayAnimationStart($event)"
Expand Down Expand Up @@ -5788,7 +5788,7 @@ export class ColumnFilter implements AfterContentInit {
const documentTarget: any = this.el ? this.el.nativeElement.ownerDocument : 'document';

this.documentClickListener = this.renderer.listen(documentTarget, 'mousedown', (event) => {
const dialogElements = document.querySelectorAll('[role="dialog"]');
const dialogElements = document.querySelectorAll('[role="filterDialog"]');
const targetIsColumnFilterMenuButton = event.target.closest('.p-column-filter-menu-button');
if (this.overlayVisible && this.isOutsideClicked(event) && (targetIsColumnFilterMenuButton || dialogElements?.length <= 1)) {
this.hide();
Expand Down