Skip to content

Improve DELETE Statement on columns with special characters in their names #25737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hantangwangd merged 1 commit into from
Aug 20, 2025
Merged

Improve DELETE Statement on columns with special characters in their names #25737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion presto-common/src/main/java/com/facebook/presto/common/SubfieldTokenizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ private Subfield.PathElement matchDollarPathElement()

private static boolean isUnquotedPathCharacter(char c)
{
return c == ':' || c == '$' || c == '-' || c == '/' || c == '@' || c == '|' || c == '#' || c == ' ' || isUnquotedSubscriptCharacter(c);
return c == ':' || c == '$' || c == '-' || c == '/' || c == '@' || c == '|' || c == '#' || c == ' ' || c == '<' || c == '>' || isUnquotedSubscriptCharacter(c);
}

private Subfield.PathElement matchUnquotedSubscript()
Expand Down
13 changes: 13 additions & 0 deletions presto-common/src/test/java/com/facebook/presto/common/TestSubfieldTokenizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,19 @@ public void testColumnNames()
assertPath(new Subfield("a and b", ImmutableList.of()));
}

@Test
public void testAngleBracketsInColumnNames()
{
assertPath(new Subfield("<>col", ImmutableList.of()));
assertPath(new Subfield("col<with>brackets", ImmutableList.of()));
assertPath(new Subfield("<>col", ImmutableList.of(new NestedField("<>field"))));
assertPath(new Subfield("table", ImmutableList.of(new NestedField("<>field"))));
assertPath(new Subfield("table", ImmutableList.of(new Subfield.StringSubscript("<>value>"))));
assertPath(new Subfield("<table>", ImmutableList.of(
new NestedField("<field>"),
new Subfield.StringSubscript("<value>"))));
}

@Test
public void testInvalidPaths()
{
Expand Down
9 changes: 9 additions & 0 deletions presto-iceberg/src/test/java/com/facebook/presto/iceberg/IcebergDistributedTestBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2051,6 +2051,15 @@ public void testHiddenColumns()
testDataSequenceNumberHiddenColumn();
}

@Test
public void testDeleteWithSpecialCharacterColumnName()
{
assertUpdate("CREATE TABLE test_special_character_column_name (\"<age>\" int, name varchar)");
assertUpdate("INSERT INTO test_special_character_column_name VALUES (1, 'abc'), (2, 'def'), (3, 'ghi')", 3);
assertUpdate("DELETE FROM test_special_character_column_name where \"<age>\" = 2", 1);
assertUpdate("DROP TABLE IF EXISTS test_special_character_column_name");
}

@Test
public void testDeletedHiddenColumn()
{
Expand Down
Loading