Add cast(ObjectId() as string) in mongodb connector #17225
Merged
+15
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschlussel
approved these changes
Jan 28, 2022
Contributor
|
This is still a draft. Are you planning to add more to it? |
Contributor
|
@Eywek If you are done, can you make this no longer a draft so I can merge it? |
Contributor
Author
|
Sorry, I haven't seen previous comments, it's ready to merge! |
Contributor
|
Thank you! can you rebase and push your branch again to restart the tests? |
Contributor
Author
|
Done! |
Contributor
|
sorry can you rebase one more time. a fix for presto-docs is landed now. |
Contributor
Author
|
yep, it's done |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14338