Skip to content

Add session key support for AWS Bedrock#12

Merged
AzizStark merged 6 commits intopresidio-oss:mainfrom
AzizStark:feature/session-key-support
Sep 19, 2025
Merged

Add session key support for AWS Bedrock#12
AzizStark merged 6 commits intopresidio-oss:mainfrom
AzizStark:feature/session-key-support

Conversation

@AzizStark
Copy link
Collaborator

Pull Request

📝 Description

🔍 Related Issues

🔄 Type of Change

  • 🐛 Bug Fix (non-breaking change addressing an issue)
  • ✨ New Feature (non-breaking change adding functionality)
  • 💥 Breaking Change (fix or feature causing existing functionality to change)
  • 📚 Documentation Update
  • 🧹 Code Refactor
  • 🔧 Build/CI Update
  • ⚡ Performance Improvement

📋 Changeset

  • Yes
  • No, this change doesn't require a version bump
  • No, will add one before merging

🧪 Testing

  • Added/updated unit tests
  • Added/updated integration tests
  • Manually tested functionality

📸 Screenshots

✅ Checklist

  • My changes generate no new warnings
  • I have updated documentation as needed
  • I have verified that my changes are accessible

📣 Additional Context

Copilot AI review requested due to automatic review settings September 12, 2025 11:12
@changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2025

⚠️ No Changeset found

Latest commit: 7c7c9fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for AWS session tokens (temporary credentials) in the Bedrock model configuration and fixes an execution retry issue. The changes enable the use of AWS temporary credentials that require a session token, which is common when using AWS STS or IAM roles.

  • Adds AWS session token support for Bedrock credentials
  • Updates credential validation and configuration messages to include session token
  • Fixes isComplete flag behavior in execution retry logic

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
packages/factifai-agent/src/core/models/models.ts Updates Bedrock model credentials to conditionally include AWS session token
packages/factifai-agent/src/cli.ts Adds session token display and setup instructions in configuration commands
packages/factifai-agent/src/core/nodes/execution/execution-and-verification-node.ts Changes isComplete flag from true to false on maximum retries

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@Mage1507 Mage1507 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good.

@AzizStark AzizStark merged commit 78c28d3 into presidio-oss:main Sep 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants