Skip to content

chore: bump sqlglot #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

chore: bump sqlglot #351

merged 1 commit into from
May 29, 2025

Conversation

@betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented May 29, 2025

Bump sqlglot to the latest version. There are 2 problems with this:

  1. The .walk() method yields only nodes, instead of tuples.
  2. Some Jinja can now be parsed correctly as SQL structs, resulting invalid expressions for metrics. I fixed this by detecting Jinja and falling back to the regex-based replacer.

Vitor-Avila
Vitor-Avila approved these changes May 29, 2025
View reviewed changes
Copy link
Contributor

@Vitor-Avila Vitor-Avila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@betodealmeida betodealmeida merged commit a0e5ce1 into main May 29, 2025
5 checks passed
@betodealmeida betodealmeida deleted the update-sqlglot branch May 29, 2025 12:54
@Vitor-Avila Vitor-Avila mentioned this pull request May 29, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vitor-Avila Vitor-Avila Vitor-Avila approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@betodealmeida @Vitor-Avila