feat: Support the --asset-type argument for individual imports #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vitor-Avila
commented
Jan 21, 2025
Comment on lines
+369
to
+371
| for uuid in get_related_uuids(config): | ||
| asset_configs.update(related_configs[uuid]) | ||
| related_configs[config["uuid"]] = asset_configs |
Contributor
Author
There was a problem hiding this comment.
This was already there -- we just need to make sure it's executed before the asset is skipped to be imported.
Vitor-Avila
commented
Jan 21, 2025
Comment on lines
-472
to
-473
| metadata_type = asset_type.metadata_type if asset_type else "assets" | ||
| resource_name = asset_type.resource_name if asset_type else "assets" |
Contributor
Author
There was a problem hiding this comment.
No longer necessary with the new default ResourceType.ASSET
betodealmeida
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
--asset-typeselector for individual imports. This allows users to trigger an import for a specific asset type (including dependencies) that get imported via the asset type endpoint.It also fixes a logic gap that was introduced in #328 -- while it's correct that successful files added to the
progress.logshould be skipped, they should still be added to theassets_configdict as they might be dependencies to existing assets.