chore: Write to log file after every step #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vitor-Avila
commented
Jan 14, 2025
| if logs.get("assets") | ||
| else set() | ||
| ) | ||
| client = SupersetClient(baseurl=URL(ctx.obj["INSTANCE"]), auth=ctx.obj["AUTH"]) |
Contributor
Author
There was a problem hiding this comment.
I was getting a too-many-locals complain, so did this to avoid adding the skip check
betodealmeida
approved these changes
Jan 14, 2025
| if logs: | ||
| write_logs_to_file(logs) | ||
| logs.pop(log_type.value, None) | ||
| if any(logs.values()): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the remaining feedback from #331 + enforces the progress is written to the log file continuously (as opposed to just at the end) so that if the command is aborted/cancelled progress is stored.