Skip to content

Conversation

@Vitor-Avila
Copy link
Contributor

This PR removes the --preserve-columns flag, as it's been re-named to --preserve-metadata in #238.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might need to freeze pylint in setup.cfg to 2.15.5?

@Vitor-Avila
Copy link
Contributor Author

I think we might need to freeze pylint in setup.cfg to 2.15.5?

Great catch. Let me do that.

@Vitor-Avila
Copy link
Contributor Author

That didn't work. I think we need to bump pycln to https://github.com/hadialqattan/pycln/releases/tag/v2.5.0. Just did that -- let's see 🤞

@Vitor-Avila Vitor-Avila merged commit 120d377 into main Jan 7, 2025
5 checks passed
@Vitor-Avila Vitor-Avila deleted the chore/deprecate-preserve-columns branch January 7, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants