add options for NERDCommenterToggle to check all lines #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hey thanks for the contribution! This is really cool and something I've wanted before. In fact I think there is an open issue / feature request for this somewhere. I'll have to search for that no notify others who were looking for this. |
alerque
requested changes
Jun 21, 2018
Member
alerque
left a comment
alerque
left a comment
There was a problem hiding this comment.
Can I ask that you also edit the help file and readme documentation with information about what this option does and how to use it. Your description in the PR is a good start but that should be documented in the plugin itself so people can find it in vim help and the project readme. Thanks!
Contributor
Author
|
I update the doc and readme, please check~ |
alerque
approved these changes
Jun 21, 2018
Member
|
Looks good, thanks again for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes I need to comment a paragraph, but the first line is comment.
So I added an option, the default is 0, as before.
After set to 1, NERDCommenterToggle will detect each line, if there have oneline not be commented, then comment all lines.