Handle ESM wrapper's embed method in peer callback - #176
Merged
Conversation
added 4 commits
July 31, 2025 19:47
…ously just tokenized inputs
ncfrey
approved these changes
Aug 1, 2025
| is_tokenized_input = isinstance(inputs, (dict, BatchEncoding)) | ||
| isinstance(inputs, (list, str)) | ||
|
|
||
| # Check for dangerous combinations |
taylormjs
marked this pull request as ready for review
August 1, 2025 16:07
taylormjs
added a commit
that referenced
this pull request
Aug 1, 2025
* handle embed methods that take in sequence or tokenized inputs (previously just tokenized inputs * clean up, add warnings * ruff * fix error chaining --------- Co-authored-by: Taylor Joren <joren.taylor@gene.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The ESM wrapper's embed method expects sequences, not tokenized inputs. The PEER evals, however, previously assumed embed took in tokenized inputs. Updating peer callback to account for this
Type of Change