-
Notifications
You must be signed in to change notification settings - Fork 20
feat: Allow caching global environment(s) #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow caching global environment(s) #226
Conversation
3f60898 to
299140a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly looks good 👍🏻 feel free to create a pr to update the pixi docs as well.
can you bump the version in package.json to 0.9.2?
69411aa to
59969fd
Compare
8b050e6 to
508686f
Compare
Done. pixi PR is here: prefix-dev/pixi#4672 |
|
@pavelzw thanks for your review and comments. I have actioned all of them. The global cache will also cache the pixi binary. as the hash takes the binary into account, we should be fine, but maybe there is a way to do better, and skip pixi installation if it can be restored from the global cache? Any way, just a thought; and that could be done in a followup PR. |
|
@pavelzw gentle ping 😄 . the documentation has now been updated on the main pixi doc website. |
pavelzw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the delay, your pings didn't reach me for some reason
@pavelzw , this PR brings back the option to cache global environments. To take into account your comment around the lack of lock file making this a bit more tricky, I have:
let me know what you think!