Skip to content

ESLint: Migrate to flat config, isolate Prettier, fix errors#120

Merged
pavelzw merged 12 commits intoprefix-dev:mainfrom
jens-ox:main
Jun 14, 2024
Merged

ESLint: Migrate to flat config, isolate Prettier, fix errors#120
pavelzw merged 12 commits intoprefix-dev:mainfrom
jens-ox:main

Conversation

@jens-ox
Copy link
Copy Markdown
Contributor

@jens-ox jens-ox commented Jun 11, 2024

Hi all!
This PR updates ESLint to the new flat config format. Additionally, the following things have been done:

  • separate Prettier and ESLint (as recommended by Prettier)
  • move to typescript-eslint
  • remove old ESLint configurations and plugins
  • fix issues detected by new config
  • update scripts in package.json to include Prettier in CI

@jens-ox jens-ox requested a review from pavelzw as a code owner June 11, 2024 09:28
@jens-ox jens-ox marked this pull request as draft June 13, 2024 08:33
@jens-ox jens-ox marked this pull request as ready for review June 13, 2024 11:47
Comment thread .prettierignore Outdated
@@ -0,0 +1 @@
dist No newline at end of file
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dist
dist

Comment thread .gitignore Outdated
.idea

# ESBuild metafile
metafile*.json No newline at end of file
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
metafile*.json
metafile*.json

Comment thread README.md
- uses: prefix-dev/[email protected]
with:
environments: ${{ matrix.environment }}
- uses: actions/checkout@v4
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is checked by prettier, right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Comment thread src/main.ts
if (core.isDebug()) {
throw error
})
.then(() => exit(0)) // workaround for https://github.com/actions/toolkit/issues/1578
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep this line, see #113

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll also add it to post.ts then

Copy link
Copy Markdown
Collaborator

@pavelzw pavelzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pavelzw pavelzw merged commit a9af475 into prefix-dev:main Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants