fix: follow symlinks to directories in glob pattern matching#5502
Merged
nichmor merged 1 commit intoprefix-dev:mainfrom Feb 18, 2026
Merged
Conversation
Enable `follow_links(true)` on the `ignore::WalkBuilder` so that symlinks pointing to directories are traversed instead of being reported as opaque entries. Without this, a symlinked directory was returned as a file-like entry, causing "Is a directory (os error 21)" when downstream code attempted to read it. Closes prefix-dev#5417 https://claude.ai/code/session_01MmEyYFc57asgHgTTBV8nAr
nichmor
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable symlink following in the glob pattern walker to discover files inside symlinked directories. This fixes an issue where glob patterns like
**would not match files located within symlinked directories.The change is minimal and focused:
follow_links(true)on theignore::WalkBuilderto traverse symlinked directoriesFixes #5417
How Has This Been Tested?
Added a new test
symlink_to_directory_is_followedthat:**discovers both regular files and files within the symlinked directoryThe test is Unix-only (marked with
#[cfg(unix)]) since symlink creation differs across platforms.AI Disclosure
Written by Claude Code Opus 4.6 Extended.
Checklist: