Skip to content

fix: ignore PIXI_ env vars when --manifest-path is different to PIXI_PROJECT_ROOT#5441

Merged
Hofer-Julian merged 8 commits intoprefix-dev:mainfrom
Hofer-Julian:push-pkvumyozulst
Feb 10, 2026
Merged

fix: ignore PIXI_ env vars when --manifest-path is different to PIXI_PROJECT_ROOT#5441
Hofer-Julian merged 8 commits intoprefix-dev:mainfrom
Hofer-Julian:push-pkvumyozulst

Conversation

@Hofer-Julian
Copy link
Contributor

@Hofer-Julian Hofer-Julian commented Feb 4, 2026

Description

Fixes #5395

How Has This Been Tested?

Added tests and verified behaviour locally with pixi run install-as pixid

AI Disclosure

  • This PR contains AI-generated content.
    • I have tested any AI-generated content in my PR.
    • I take responsibility for any AI-generated content in my PR.

Tools: Claude

Checklist:

  • I have performed a self-review of my own code

  • I have commented my code, particularly in hard-to-understand areas

  • I have added sufficient tests to cover my changes.

@Hofer-Julian Hofer-Julian changed the title Push pkvumyozulst Ignore PIXI_ env vars when --manifest-path is different to PIXI_PROJECT_ROOT Feb 4, 2026
@Hofer-Julian Hofer-Julian changed the title Ignore PIXI_ env vars when --manifest-path is different to PIXI_PROJECT_ROOT fix: ignore PIXI_ env vars when --manifest-path is different to PIXI_PROJECT_ROOT Feb 4, 2026
@Hofer-Julian Hofer-Julian force-pushed the push-pkvumyozulst branch 4 times, most recently from b3f5b58 to 90cd437 Compare February 5, 2026 10:31
Hofer-Julian and others added 4 commits February 10, 2026 11:12
The fix in the previous commit properly ignores inherited PIXI_ environment
variables when the workspace root differs from PIXI_PROJECT_ROOT, making
explicit env var removal workarounds unnecessary.
@Hofer-Julian Hofer-Julian marked this pull request as ready for review February 10, 2026 14:37
… crash

The test constructed a `file://` URL by string concatenation
(`"file://" + path.as_posix()`), which on Windows produced `file://C:/...`
(two slashes). This is malformed — `C:` gets parsed as a hostname in the URL
authority. The correct form is `file:///C:/...` (three slashes). On Linux the
bug was latent because paths start with `/`, giving the correct three slashes
by accident.

`Path.as_uri()` handles this correctly on all platforms.
The test crashes the pytest-xdist worker on Windows. Skip for now until the
underlying issue is resolved.
Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Hofer-Julian Hofer-Julian merged commit 0da0589 into prefix-dev:main Feb 10, 2026
37 checks passed
@Hofer-Julian Hofer-Julian deleted the push-pkvumyozulst branch February 10, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ignore PIXI_ env vars when --manifest-path is different to PIXI_PROJECT_ROOT

2 participants