fix: installing mallformed wheels#5387
Conversation
tdejager
left a comment
There was a problem hiding this comment.
Nice! This might needs some documentation, also I'm unsure about the UV_ prefix as we do not use that anywhere else our environment variables, so we could just drop the prefix maybe. Also, unsure about this but maybe this should even be a pypi-option, what do you think @ruben-arts ?
Thanks! Yeah, the idea why I'm inclined to use regarding the |
Yeah I get that reasoning, but I'm on the fence in the sense that if as a user I see a |
|
Good points guys! Would it be easy to just enable all uv flags? This would give a little bit of a "hands off" appoarch from ourside to our users, they could play around with fixing their special installation requirements. I normally don't like to support environment variables that make the installation undeterministic but since it can also unblock users in these strange cases, so it's probably a good start. I would vote to also add the |
Yeah I was wondering that too, but its just a bit complicated because of a lot of them aren't applicable to our environment solving use case. But a bunch of them are though, apparently the structure Would be good to do a sit-down at some point and decide what env variables to expose though. |
Yes! regarding the other env flags - we need to plan what we want to expose maybe both for rattler and uv, and what env flags we will use only for uv. I think a sit-down will be a good idea for this |
Description
The origin issue appear to be that the wheels that our users try to install are malformed ( see similar issue here : astral-sh/uv#8082 )
uvallows to bypass this check, by setting a env flag. This PR introduce ability to set uv_flag's ( not all, only the one that we are aware of ) from our side.also adds
pypi-optionsfor itskip-wheel-filename-checkFixes: #5305
How Has This Been Tested?
Manually and adding a integration test.
AI Disclosure
Tools: Claude
Checklist:
schema/model.py.