fix: fish shell integration is broken on older version of fish#5225
Merged
baszalmstra merged 1 commit intomainfrom Jan 20, 2026
Merged
fix: fish shell integration is broken on older version of fish#5225baszalmstra merged 1 commit intomainfrom
baszalmstra merged 1 commit intomainfrom
Conversation
Replace `fish_add_path` with `set -gx PATH` for compatibility with Fish versions older than 3.2.0 (e.g., Fish 3.1.0 on Ubuntu 20.04). This is consistent with how bash/zsh PATH setup is handled in the same script. Fixes #5210
Contributor
Author
|
@melonedo can you give this a go? |
|
It should work if I modify |
Contributor
Author
|
I think uninstall and reinstalling from the script 🙂 |
I am sorry, but doesn't |
Contributor
Author
|
That does not really matter right? As long as you clone the repository locally and then test the script directly? |
Yes, AFAICT it works. |
ruben-arts
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
fish_add_pathwithset -gx PATHfor compatibility with Fish versions older than 3.2.0 (e.g., Fish 3.1.0 on Ubuntu 20.04).This is consistent with how bash/zsh PATH setup is handled in the same script.
Description
Fixes #5210
How Has This Been Tested?
AI Disclosure
Tools: Sonnet
Checklist:
schema/model.py.