fix(build): double relative manifest path #4699
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
When
--manifest-pathis specified forpixi buildit gets double prefixed and fails with error like this:Which happens because given manifest path is added to the discovered workspace root directory.
Solution
Compute relative path from workspace root to the given (canonicalized) manifest path.
Testing
Run following command from the root dir of the repository to test that it doesn't work on main:
and run
to see that it works with this fix.
Notes
I'm still not quite sure that this fix is a correct way to do it, since we have more logic in the
resolve_typed_path, so feedback is appreciated!