Skip to content

Conversation

@fstanis
Copy link
Contributor

@fstanis fstanis commented Sep 25, 2025

This fixes #4650 and is more aligned with how conda behaves.

@fstanis fstanis changed the title Restore $status before calling __fish_prompt_orig fix: restore $status before calling __fish_prompt_orig Sep 26, 2025
@tdejager
Copy link
Contributor

Can't seem to figure out how this behavior differs from main. Can you maybe paste the original and modified terminal outputs? I also use tide and never noticed something strange :)

@fstanis
Copy link
Contributor Author

fstanis commented Sep 30, 2025

The current code calls __fish_prompt_orig right after __pixi_add_prompt. This means that if __fish_prompt_orig reads $status, it will be the return status of __pixi_add_prompt.

In practice this means something like tide never displays the status code, i.e. it's supposed to look like this (notice 127 on the right):

{42F87B05-F326-4F32-8067-8A04C0E1930E}

While pixi is active, I never get any code displayed on the right.

Copy link
Contributor

tdejager commented Oct 1, 2025

Ah yeah I see! Ok lets merge!

@tdejager tdejager merged commit ddd2787 into prefix-dev:main Oct 1, 2025
38 checks passed
@Hofer-Julian
Copy link
Contributor

Thanks @fstanis!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fish_prompt prevents existing prompt from reading $status

3 participants