fix(pypi): use source name for a package #4597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdejager
approved these changes
Sep 16, 2025
nichmor
force-pushed
the
fix/uninstall-with-dash-in-the-name
branch
from
213f01e to
826199d
Compare
lucascolley
added
bug
lucascolley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4187
Overview
A very simple fix for a funny problem!
The idea is that, if you store an un-normalized PyPI name
pixi_demoin thepyproject.tomland then request to remove it withYou will not be able to because during the conversion from pixi_demo to pep requirement name, we normalized it, so we always lose the source name.
On the other hand, TomlDocument is
rawloaded, without any normalisation - this means that we need to preserve the source of the requested name and use it to find it.At the same time,
will not remove it from the manifest ( stored pixi_demo), because we never normalise names when loading
TomlDocument( which is expected )