fix: Add an early check, before creating directories for <non-existent-env> while uninstalling them#4049
Merged
nichmor merged 2 commits intoprefix-dev:mainfrom Jul 2, 2025
Conversation
baszalmstra
approved these changes
Jul 1, 2025
Contributor
|
tested with cargo run -- global uninstall example-dirWorks as expected! |
nichmor
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4032
From what I could understand, while uninstalling the env, the directory was always being created because of the
tokio_fs::create_dir_all(&path).awaitcall fromremove_environment()insrc/global/project/mod.rsSo just added a check before that. I checked it locally by building the pixi and it works. hope this fixes the issue:)