Conversation
IshaanDesai
left a comment
There was a problem hiding this comment.
Good first steps, but we need to do a bit more work before merging this. Please look at the comments below. A general comment is writing comments in the code such that it is readable. I will do another round of reviewing soon.
|
The latest commit adds interpolation. Besides lacking extrapolation, scipy's griddata module also cannot interpolate on linearly dependent data, thus data on the dummy problems cannot be interpolated. more thought must be put into the issue, to interpolate and extrapolate all cases of simulation crashes, and implementing a custom solution for interpolation is most likely required. |
|
Further discussions led to the idea that implementing an inverse distance weighing would make sense for the interpolation. This would be done with a k-nearest-neighbor method, where the user can set k. |
40c1f95 to
e6c3baf
Compare
IshaanDesai
left a comment
There was a problem hiding this comment.
Good effort already 👍 my suggestions are mainly about code styling. Let us test this functionality on a real example and check if crashes are caught.
Co-authored-by: Ishaan Desai <ishaandesai@gmail.com>
5ea8a70 to
1dc33ce
Compare
IshaanDesai
left a comment
There was a problem hiding this comment.
We are getting closer to merging this 😁 some more comments on my side. The logic and overall code looks good now.
Co-authored-by: Ishaan Desai <ishaandesai@gmail.com>
IshaanDesai
left a comment
There was a problem hiding this comment.
Good to go 👍 please remember to squash and merge.
This is an attempt to solve issue #74.
This cannot be a permanent solution to the handling of crashing simulation. If a simulation crashes during the first time step, it is replaced with data from another random simulation. In the long run, I don't see any other solution than an interpolation (in cases where only one simulation is given and it cannot be replaced by one of different complexity).
Moreover, it has not been tested with real simulations, in parallel, or using spack.