New feature: model adaptivity#198
Merged
IshaanDesai merged 26 commits intodevelopfrom Dec 10, 2025
Merged
Conversation
IshaanDesai
reviewed
Nov 13, 2025
Member
IshaanDesai
left a comment
IshaanDesai
left a comment
There was a problem hiding this comment.
Good work already! I did a first pass, in which I looked at everything except the tests. I would like to do another review before we finalize things, especially to look at the model_adaptivity.py once more. Please take a look at my comments.
Co-authored-by: Ishaan Desai <ishaandesai@gmail.com>
Co-authored-by: Ishaan Desai <ishaandesai@gmail.com>
Co-authored-by: Ishaan Desai <ishaandesai@gmail.com>
Co-authored-by: Ishaan Desai <ishaandesai@gmail.com>
Co-authored-by: Ishaan Desai <ishaandesai@gmail.com>
Co-authored-by: Ishaan Desai <ishaandesai@gmail.com>
IshaanDesai
changed the title
IshaanDesai
changed the title
2 tasks
IshaanDesai
approved these changes
Dec 2, 2025
Member
IshaanDesai
left a comment
IshaanDesai
left a comment
There was a problem hiding this comment.
The code for the functionality looks good 👍. I have some suggestions for structuring and file/code placement. Once those are incorporated, this can be merged.
Co-authored-by: Ishaan Desai <ishaandesai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for multiple micro models and mocked switching.
Multi-Model support via ModelAdaptivity class.
Switching currently hard coded as: upper half of all sims in the micro_sims list are set to use the second MicroSim type.
Checklist:
CHANGELOG.md.