Handle adaptivity case when deactivation and activation happens in the same time window#165
Merged
IshaanDesai merged 2 commits intodevelopfrom May 13, 2025
Merged
Handle adaptivity case when deactivation and activation happens in the same time window#165IshaanDesai merged 2 commits intodevelopfrom
IshaanDesai merged 2 commits intodevelopfrom
Conversation
…r activation in the same step
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a simulation is deactivated and then tagged for activation in the same time window, it does not have an associated active simulation to get the state from. The association is also not necessary, because the current state can simply be carried forward. This PR handles this case in the global and local adaptivity.
Checklist:
CHANGELOG.md.