Fix bug in handling of vector data#143
Merged
IshaanDesai merged 7 commits intodevelopfrom Jan 27, 2025
Merged
Conversation
… a micro simulation object
…ing unit test passes
mathiskelm
approved these changes
Jan 27, 2025
Collaborator
mathiskelm
left a comment
mathiskelm
left a comment
There was a problem hiding this comment.
Fixes issue #144 also in my application. Looks good!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Micro Manager could not handle the case where a micro simulation returns vector data in the form of a list. This was because the data collection for adaptivity was done on a predefined
numpy.arraydata structure. Now the data collection is done in a Python list and the list is converted to a NumPy array only just before the data is used for the similarity calculation.Checklist:
CHANGELOG.md.