Skip to content

Put computation of counting active steps inside the adaptivity variant condition#130

Merged
IshaanDesai merged 2 commits intodevelopfrom
fix_active_steps
Sep 16, 2024
Merged

Put computation of counting active steps inside the adaptivity variant condition#130
IshaanDesai merged 2 commits intodevelopfrom
fix_active_steps

Conversation

@IshaanDesai
Copy link
Copy Markdown
Member

@IshaanDesai IshaanDesai commented Sep 16, 2024

Fixes #122

Checklist:

  • I made sure that the CI passed before I ask for a review.
  • I added a summary of the changes (compared to the last release) in the CHANGELOG.md.
  • If necessary, I made changes to the documentation and/or added new content.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@IshaanDesai IshaanDesai self-assigned this Sep 16, 2024
@IshaanDesai IshaanDesai added the bug Something isn't working label Sep 16, 2024
@IshaanDesai IshaanDesai marked this pull request as ready for review September 16, 2024 14:22
Copy link
Copy Markdown
Collaborator

@mathiskelm mathiskelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for adding the fix.

@IshaanDesai IshaanDesai merged commit c815977 into develop Sep 16, 2024
@IshaanDesai IshaanDesai deleted the fix_active_steps branch September 16, 2024 15:13
@IshaanDesai IshaanDesai mentioned this pull request Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Overcounted active steps when using adaptivity in every implicit iteration

2 participants