Explicitly check if the time window has completed#118
Merged
IshaanDesai merged 2 commits intodevelopfrom Jul 30, 2024
Merged
Conversation
solve() if the time window has completed
BenjaminRodenberg
approved these changes
Jul 29, 2024
Contributor
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
Looks ok. Before there was clearly something wrong if you are using subcycling.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the Micro Manager understands that a time window has converged when the API call
requires_reading_checkpoint()is false. However,requires_reading_checkpoint()may return false when the time window has not converged. This could happen, for example, when the Micro Manager is subcycling. To avoid falsely indicating convergence in the Micro Manager, an explicit check using the API commandis_time_window_complete()is necessary.Checklist:
CHANGELOG.md.