Skip to content

Rubicon Bid Adapter: Remove Topics support #14242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patmmccann merged 3 commits into from
Dec 8, 2025
Merged

Rubicon Bid Adapter: Remove Topics support #14242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
935df11
Remove unused segment tax functions and related tests from rubiconBid…
apukh-magnite Dec 5, 2025
d758e03
Merge branch 'master' of https://github.com/prebid/Prebid.js into chrome
apukh-magnite Dec 5, 2025
8b82ea6
Remove test for o_ae parameter in rubicon adapter when fledge is enabled
apukh-magnite Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions modules/rubiconBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,6 @@ export const spec = {
data['p_site.mobile'] = bidRequest.ortb2.site.mobile
}

addDesiredSegtaxes(bidderRequest, data);
// loop through userIds and add to request
if (bidRequest?.ortb2?.user?.ext?.eids) {
bidRequest.ortb2.user.ext.eids.forEach(({ source, uids = [], inserter, matcher, mm, ext = {} }) => {
Expand Down Expand Up @@ -1052,27 +1051,6 @@ function applyFPD(bidRequest, mediaType, data) {
}
}

function addDesiredSegtaxes(bidderRequest, target) {
if (rubiConf.readTopics === false) {
return;
}
const iSegments = [1, 2, 5, 6, 7, 507].concat(rubiConf.sendSiteSegtax?.map(seg => Number(seg)) || []);
const vSegments = [4, 508].concat(rubiConf.sendUserSegtax?.map(seg => Number(seg)) || []);
const userData = bidderRequest.ortb2?.user?.data || [];
const siteData = bidderRequest.ortb2?.site?.content?.data || [];
userData.forEach(iterateOverSegmentData(target, 'v', vSegments));
siteData.forEach(iterateOverSegmentData(target, 'i', iSegments));
}

function iterateOverSegmentData(target, char, segments) {
return (topic) => {
const taxonomy = Number(topic.ext?.segtax);
if (segments.includes(taxonomy)) {
target[`tg_${char}.tax${taxonomy}`] = topic.segment?.map(seg => seg.id).join(',');
}
}
}

/**
* @param sizes
* @returns {*}
Expand Down
73 changes: 0 additions & 73 deletions test/spec/modules/rubiconBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2890,79 +2890,6 @@ describe('the rubicon adapter', function () {
expect(slotParams.kw).to.equal('a,b,c');
});

it('should pass along desired segtaxes, but not non-desired ones', () => {
const localBidderRequest = Object.assign({}, bidderRequest);
localBidderRequest.refererInfo = {domain: 'bob'};
config.setConfig({
rubicon: {
sendUserSegtax: [9],
sendSiteSegtax: [10]
}
});
localBidderRequest.ortb2.user = {
data: [{
ext: {
segtax: '404'
},
segment: [{id: 5}, {id: 6}]
}, {
ext: {
segtax: '508'
},
segment: [{id: 5}, {id: 2}]
}, {
ext: {
segtax: '9'
},
segment: [{id: 1}, {id: 2}]
}]
}
localBidderRequest.ortb2.site = {
content: {
data: [{
ext: {
segtax: '10'
},
segment: [{id: 2}, {id: 3}]
}, {
ext: {
segtax: '507'
},
segment: [{id: 3}, {id: 4}]
}]
}
}
const slotParams = spec.createSlotParams(bidderRequest.bids[0], localBidderRequest);
expect(slotParams['tg_i.tax507']).is.equal('3,4');
expect(slotParams['tg_v.tax508']).is.equal('5,2');
expect(slotParams['tg_v.tax9']).is.equal('1,2');
expect(slotParams['tg_i.tax10']).is.equal('2,3');
expect(slotParams['tg_v.tax404']).is.equal(undefined);
});

it('should support IAB segtax 7 in site segments', () => {
const localBidderRequest = Object.assign({}, bidderRequest);
localBidderRequest.refererInfo = {domain: 'bob'};
config.setConfig({
rubicon: {
sendUserSegtax: [4],
sendSiteSegtax: [1, 2, 5, 6, 7]
}
});
localBidderRequest.ortb2.site = {
content: {
data: [{
ext: {
segtax: '7'
},
segment: [{id: 8}, {id: 9}]
}]
}
};
const slotParams = spec.createSlotParams(bidderRequest.bids[0], localBidderRequest);
expect(slotParams['tg_i.tax7']).to.equal('8,9');
});

it('should add p_site.mobile if mobile is a number in ortb2.site', function () {
// Set up a bidRequest with mobile property as a number
const localBidderRequest = Object.assign({}, bidderRequest);
Expand Down
Loading