Skip to content

Conversation

@gchicoye
Copy link
Contributor

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Instead of relying on a Nexx360 alias, this PR introduces a dedicated adapter that leverages the Nexx360 library internally. This approach:

  • Allows for implementation of adapter-specific logic without impacting the core Nexx360 module
  • Avoids code duplication by reusing the existing Nexx360 library
  • Updates the endpoint configuration accordingly

Other information

Copilot AI review requested due to automatic review settings November 25, 2025 19:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR transfers the Revnew adapter from being an alias of Nexx360 to a dedicated adapter implementation. The new adapter reuses the Nexx360 utility library (nexx360Utils) while maintaining its own endpoint configuration and adapter-specific logic.

  • Creates a new dedicated Revnew bid adapter that leverages the Nexx360 library internally
  • Updates the endpoint configuration to https://fast.nexx360.io/revnew
  • Removes the Revnew alias from the Nexx360 adapter

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.

File Description
modules/revnewBidAdapter.ts New dedicated adapter implementation with Revnew-specific configuration (GVLID 1468, endpoint, storage key) that reuses Nexx360 utility functions
test/spec/modules/revnewBidAdapter_spec.js Comprehensive test suite covering bid validation, local storage, request building, response interpretation, and user syncs
modules/revnewBidAdapter.md Documentation with adapter overview, maintainer contact, and test parameters for banner and video instream ad units
modules/nexx360BidAdapter.ts Removed Revnew from the Nexx360 aliases list

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

{ code: 'scoremedia', gvlid: 965 },
{ code: 'movingup', gvlid: 1416 },
{ code: 'glomexbidder', gvlid: 967 },
{ code: 'revnew', gvlid: 1468 },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you not want to be an alias?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @patmmccann , we're implementing specific logic here (imp.ext.revnew for instance), that's why we need to isolate this bidAdapter.

@patmmccann patmmccann self-assigned this Dec 3, 2025
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test params in the md returned an ad.

@patmmccann patmmccann merged commit 13b9d3f into prebid:master Dec 8, 2025
112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants