Skip to content

Conversation

@dpapworth-qc
Copy link
Contributor

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Remove quantcast bid adapter, as this is no longer supported by Quantcast.

Other information

@github-actions
Copy link

Tread carefully! This PR adds 139 linter errors (possibly disabled through directives):

  • creative/constants.js (+2 errors)
  • creative/crossDomain.js (+1 error)
  • creative/renderers/display/constants.js (+1 error)
  • creative/renderers/native/constants.js (+1 error)
  • libraries/analyticsAdapter/AnalyticsAdapter.ts (+1 error)
  • libraries/analyticsAdapter/examples/example2.js (+2 errors)
  • libraries/boundingClientRect/boundingClientRect.js (+1 error)
  • libraries/dspxUtils/bidderUtils.js (+2 errors)
  • libraries/liveIntentId/idSystem.js (+1 error)
  • libraries/ortb2.5StrictTranslator/dsl.js (+1 error)
  • libraries/uid2IdSystemShared/uid2IdSystem_shared.js (+1 error)
  • modules/33acrossBidAdapter.js (+1 error)
  • modules/adagioBidAdapter.js (+1 error)
  • modules/adlooxAdServerVideo.js (+1 error)
  • modules/adlooxRtdProvider.js (+1 error)
  • modules/amxBidAdapter.js (+1 error)
  • modules/big-richmediaBidAdapter.js (+1 error)
  • modules/cleanioRtdProvider.js (+1 error)
  • modules/consentManagementGpp.ts (+1 error)
  • modules/criteoIdSystem.js (+1 error)
  • modules/debugging/debugging.js (+3 errors)
  • modules/debugging/index.js (+8 errors)
  • modules/dfpAdServerVideo.js (+1 error)
  • modules/dfpAdpod.js (+1 error)
  • modules/dgkeywordRtdProvider.js (+1 error)
  • modules/eplanningBidAdapter.js (+1 error)
  • modules/euidIdSystem.js (+1 error)
  • modules/express.js (+2 errors)
  • modules/genericAnalyticsAdapter.ts (+1 error)
  • modules/geoedgeRtdProvider.js (+2 errors)
  • modules/liveIntentIdSystem.js (+3 errors)
  • modules/marsmediaBidAdapter.js (+3 errors)
  • modules/microadBidAdapter.js (+4 errors)
  • modules/mobianRtdProvider.js (+1 error)
  • modules/mobkoiAnalyticsAdapter.js (+1 error)
  • modules/nativeRendering.js (+1 error)
  • modules/nodalsAiRtdProvider.js (+1 error)
  • modules/onetagBidAdapter.js (+1 error)
  • modules/overtoneRtdProvider.js (+1 error)
  • modules/priceFloors.ts (+2 errors)
  • modules/pubmaticBidAdapter.js (+8 errors)
  • modules/pubmaticRtdProvider.js (+1 error)
  • modules/pubxaiRtdProvider.js (+1 error)
  • modules/pwbidBidAdapter.js (+1 error)
  • modules/rhythmoneBidAdapter.js (+3 errors)
  • modules/rtdModule/spec.ts (+1 error)
  • modules/smartxBidAdapter.js (+1 error)
  • modules/sonobiBidAdapter.js (+2 errors)
  • modules/storageControl.ts (+1 error)
  • modules/uid2IdSystem.js (+1 error)
  • modules/underdogmediaBidAdapter.js (+1 error)
  • modules/userId/spec.ts (+2 errors)
  • modules/yahooAdsBidAdapter.js (+1 error)
  • modules/yieldoneAnalyticsAdapter.js (+1 error)
  • src/activities/rules.js (+1 error)
  • src/adUnits.ts (+1 error)
  • src/ajax.ts (+1 error)
  • src/auction.ts (+1 error)
  • src/bidderSettings.ts (+1 error)
  • src/bidfactory.ts (+1 error)
  • src/buildOptions.ts (+3 errors)
  • src/consentHandler.ts (+1 error)
  • src/cpmBucketManager.ts (+1 error)
  • src/creativeRenderers.js (+1 error)
  • src/debugging.js (+1 error)
  • src/events.ts (+1 error)
  • src/storageManager.ts (+2 errors)
  • src/types/local/gpt.d.ts (+1 error)
  • src/utils.js (+9 errors)
  • test/fake-server/fake-responder.js (+2 errors)
  • test/fake-server/fixtures/index.js (+1 error)
  • test/fake-server/index.js (+1 error)
  • test/mocks/xhr.js (+4 errors)
  • test/pipeline_setup.js (+2 errors)
  • test/spec/auctionmanager_spec.js (+2 errors)
  • test/spec/libraries/greedy/greedyPromise_spec.js (+2 errors)
  • test/spec/modules/criteoBidAdapter_spec.js (+1 error)
  • test/spec/modules/intentIqIdSystem_spec.js (+3 errors)
  • test/spec/modules/msftBidAdapter_spec.js (+1 error)
  • test/spec/modules/nativoBidAdapter_spec.js (+1 error)
  • test/spec/modules/prebidServerBidAdapter_spec.js (+1 error)
  • test/spec/modules/riseBidAdapter_spec.js (+2 errors)
  • test/spec/utils_spec.js (+1 error)
  • test/test_deps.js (+2 errors)

@github-actions
Copy link

Tread carefully! This PR adds 139 linter errors (possibly disabled through directives):

  • creative/constants.js (+2 errors)
  • creative/crossDomain.js (+1 error)
  • creative/renderers/display/constants.js (+1 error)
  • creative/renderers/native/constants.js (+1 error)
  • libraries/analyticsAdapter/AnalyticsAdapter.ts (+1 error)
  • libraries/analyticsAdapter/examples/example2.js (+2 errors)
  • libraries/boundingClientRect/boundingClientRect.js (+1 error)
  • libraries/dspxUtils/bidderUtils.js (+2 errors)
  • libraries/liveIntentId/idSystem.js (+1 error)
  • libraries/ortb2.5StrictTranslator/dsl.js (+1 error)
  • libraries/uid2IdSystemShared/uid2IdSystem_shared.js (+1 error)
  • modules/33acrossBidAdapter.js (+1 error)
  • modules/adagioBidAdapter.js (+1 error)
  • modules/adlooxAdServerVideo.js (+1 error)
  • modules/adlooxRtdProvider.js (+1 error)
  • modules/amxBidAdapter.js (+1 error)
  • modules/big-richmediaBidAdapter.js (+1 error)
  • modules/cleanioRtdProvider.js (+1 error)
  • modules/consentManagementGpp.ts (+1 error)
  • modules/criteoIdSystem.js (+1 error)
  • modules/debugging/debugging.js (+3 errors)
  • modules/debugging/index.js (+8 errors)
  • modules/dfpAdServerVideo.js (+1 error)
  • modules/dfpAdpod.js (+1 error)
  • modules/dgkeywordRtdProvider.js (+1 error)
  • modules/eplanningBidAdapter.js (+1 error)
  • modules/euidIdSystem.js (+1 error)
  • modules/express.js (+2 errors)
  • modules/genericAnalyticsAdapter.ts (+1 error)
  • modules/geoedgeRtdProvider.js (+2 errors)
  • modules/liveIntentIdSystem.js (+3 errors)
  • modules/marsmediaBidAdapter.js (+3 errors)
  • modules/microadBidAdapter.js (+4 errors)
  • modules/mobianRtdProvider.js (+1 error)
  • modules/mobkoiAnalyticsAdapter.js (+1 error)
  • modules/nativeRendering.js (+1 error)
  • modules/nodalsAiRtdProvider.js (+1 error)
  • modules/onetagBidAdapter.js (+1 error)
  • modules/overtoneRtdProvider.js (+1 error)
  • modules/priceFloors.ts (+2 errors)
  • modules/pubmaticBidAdapter.js (+8 errors)
  • modules/pubmaticRtdProvider.js (+1 error)
  • modules/pubxaiRtdProvider.js (+1 error)
  • modules/pwbidBidAdapter.js (+1 error)
  • modules/rhythmoneBidAdapter.js (+3 errors)
  • modules/rtdModule/spec.ts (+1 error)
  • modules/smartxBidAdapter.js (+1 error)
  • modules/sonobiBidAdapter.js (+2 errors)
  • modules/storageControl.ts (+1 error)
  • modules/uid2IdSystem.js (+1 error)
  • modules/underdogmediaBidAdapter.js (+1 error)
  • modules/userId/spec.ts (+2 errors)
  • modules/yahooAdsBidAdapter.js (+1 error)
  • modules/yieldoneAnalyticsAdapter.js (+1 error)
  • src/activities/rules.js (+1 error)
  • src/adUnits.ts (+1 error)
  • src/ajax.ts (+1 error)
  • src/auction.ts (+1 error)
  • src/bidderSettings.ts (+1 error)
  • src/bidfactory.ts (+1 error)
  • src/buildOptions.ts (+3 errors)
  • src/consentHandler.ts (+1 error)
  • src/cpmBucketManager.ts (+1 error)
  • src/creativeRenderers.js (+1 error)
  • src/debugging.js (+1 error)
  • src/events.ts (+1 error)
  • src/storageManager.ts (+2 errors)
  • src/types/local/gpt.d.ts (+1 error)
  • src/utils.js (+9 errors)
  • test/fake-server/fake-responder.js (+2 errors)
  • test/fake-server/fixtures/index.js (+1 error)
  • test/fake-server/index.js (+1 error)
  • test/mocks/xhr.js (+4 errors)
  • test/pipeline_setup.js (+2 errors)
  • test/spec/auctionmanager_spec.js (+2 errors)
  • test/spec/libraries/greedy/greedyPromise_spec.js (+2 errors)
  • test/spec/modules/criteoBidAdapter_spec.js (+1 error)
  • test/spec/modules/intentIqIdSystem_spec.js (+3 errors)
  • test/spec/modules/msftBidAdapter_spec.js (+1 error)
  • test/spec/modules/nativoBidAdapter_spec.js (+1 error)
  • test/spec/modules/prebidServerBidAdapter_spec.js (+1 error)
  • test/spec/modules/riseBidAdapter_spec.js (+2 errors)
  • test/spec/utils_spec.js (+1 error)
  • test/test_deps.js (+2 errors)

@github-actions
Copy link

Tread carefully! This PR adds 139 linter errors (possibly disabled through directives):

  • creative/constants.js (+2 errors)
  • creative/crossDomain.js (+1 error)
  • creative/renderers/display/constants.js (+1 error)
  • creative/renderers/native/constants.js (+1 error)
  • libraries/analyticsAdapter/AnalyticsAdapter.ts (+1 error)
  • libraries/analyticsAdapter/examples/example2.js (+2 errors)
  • libraries/boundingClientRect/boundingClientRect.js (+1 error)
  • libraries/dspxUtils/bidderUtils.js (+2 errors)
  • libraries/liveIntentId/idSystem.js (+1 error)
  • libraries/ortb2.5StrictTranslator/dsl.js (+1 error)
  • libraries/uid2IdSystemShared/uid2IdSystem_shared.js (+1 error)
  • modules/33acrossBidAdapter.js (+1 error)
  • modules/adagioBidAdapter.js (+1 error)
  • modules/adlooxAdServerVideo.js (+1 error)
  • modules/adlooxRtdProvider.js (+1 error)
  • modules/amxBidAdapter.js (+1 error)
  • modules/big-richmediaBidAdapter.js (+1 error)
  • modules/cleanioRtdProvider.js (+1 error)
  • modules/consentManagementGpp.ts (+1 error)
  • modules/criteoIdSystem.js (+1 error)
  • modules/debugging/debugging.js (+3 errors)
  • modules/debugging/index.js (+8 errors)
  • modules/dfpAdServerVideo.js (+1 error)
  • modules/dfpAdpod.js (+1 error)
  • modules/dgkeywordRtdProvider.js (+1 error)
  • modules/eplanningBidAdapter.js (+1 error)
  • modules/euidIdSystem.js (+1 error)
  • modules/express.js (+2 errors)
  • modules/genericAnalyticsAdapter.ts (+1 error)
  • modules/geoedgeRtdProvider.js (+2 errors)
  • modules/liveIntentIdSystem.js (+3 errors)
  • modules/marsmediaBidAdapter.js (+3 errors)
  • modules/microadBidAdapter.js (+4 errors)
  • modules/mobianRtdProvider.js (+1 error)
  • modules/mobkoiAnalyticsAdapter.js (+1 error)
  • modules/nativeRendering.js (+1 error)
  • modules/nodalsAiRtdProvider.js (+1 error)
  • modules/onetagBidAdapter.js (+1 error)
  • modules/overtoneRtdProvider.js (+1 error)
  • modules/priceFloors.ts (+2 errors)
  • modules/pubmaticBidAdapter.js (+8 errors)
  • modules/pubmaticRtdProvider.js (+1 error)
  • modules/pubxaiRtdProvider.js (+1 error)
  • modules/pwbidBidAdapter.js (+1 error)
  • modules/rhythmoneBidAdapter.js (+3 errors)
  • modules/rtdModule/spec.ts (+1 error)
  • modules/smartxBidAdapter.js (+1 error)
  • modules/sonobiBidAdapter.js (+2 errors)
  • modules/storageControl.ts (+1 error)
  • modules/uid2IdSystem.js (+1 error)
  • modules/underdogmediaBidAdapter.js (+1 error)
  • modules/userId/spec.ts (+2 errors)
  • modules/yahooAdsBidAdapter.js (+1 error)
  • modules/yieldoneAnalyticsAdapter.js (+1 error)
  • src/activities/rules.js (+1 error)
  • src/adUnits.ts (+1 error)
  • src/ajax.ts (+1 error)
  • src/auction.ts (+1 error)
  • src/bidderSettings.ts (+1 error)
  • src/bidfactory.ts (+1 error)
  • src/buildOptions.ts (+3 errors)
  • src/consentHandler.ts (+1 error)
  • src/cpmBucketManager.ts (+1 error)
  • src/creativeRenderers.js (+1 error)
  • src/debugging.js (+1 error)
  • src/events.ts (+1 error)
  • src/storageManager.ts (+2 errors)
  • src/types/local/gpt.d.ts (+1 error)
  • src/utils.js (+9 errors)
  • test/fake-server/fake-responder.js (+2 errors)
  • test/fake-server/fixtures/index.js (+1 error)
  • test/fake-server/index.js (+1 error)
  • test/mocks/xhr.js (+4 errors)
  • test/pipeline_setup.js (+2 errors)
  • test/spec/auctionmanager_spec.js (+2 errors)
  • test/spec/libraries/greedy/greedyPromise_spec.js (+2 errors)
  • test/spec/modules/criteoBidAdapter_spec.js (+1 error)
  • test/spec/modules/intentIqIdSystem_spec.js (+3 errors)
  • test/spec/modules/msftBidAdapter_spec.js (+1 error)
  • test/spec/modules/nativoBidAdapter_spec.js (+1 error)
  • test/spec/modules/prebidServerBidAdapter_spec.js (+1 error)
  • test/spec/modules/riseBidAdapter_spec.js (+2 errors)
  • test/spec/utils_spec.js (+1 error)
  • test/test_deps.js (+2 errors)

@dpapworth-qc
Copy link
Contributor Author

hey all! should i fix the linter errors?

@patmmccann
Copy link
Collaborator

no those are just showing up bc there are no new or edited files so it looks everywhere

@dpapworth-qc
Copy link
Contributor Author

hi all! is there an ETA for merging this PR? it's been open for a while. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants