-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New adapter: clydo #13936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New adapter: clydo #13936
Conversation
jsnellbaker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @cto-clydo
I took a look through the adapter code, and there are a number of areas that should not be needed (as you're using the ortbConverter) or just need another review.
Can you please take a look?
|
@cto-clydo thank you for making the various updates. Are the bid params values in the description a valid set? When I was attempting to run this adapter in the hello_world.html page, I was seeing the following errors: |
|
@jsnellbaker thank you for the review, it's mocked parameters in tests, you can use this to test connection
|
|
@cto-clydo thank you for the updated params. I gave them a try but I've been seeing 204 No Content responses from the endpoint. To clarify here is a copy of the request to the endpoint with its payload. Can you take a look to see if everything appears correct? |
|
@jsnellbaker We've added some test demand. You can try again with the same payload. Your request is correct |
jsnellbaker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cto-clydo thank you for making the additional updates to provide a test creative for a delivery test. Confirmed the delivery is working and the ad rendered fine.
LGTM
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
This PR introduces a new Clydo bid adapter for Prebid.js with support for banner, video and native.
Contacts
Maintainer Email: [email protected]
Company: Clydo
Test Parameters: