Skip to content

Conversation

@cto-clydo
Copy link
Contributor

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

This PR introduces a new Clydo bid adapter for Prebid.js with support for banner, video and native.

Contacts

Maintainer Email: [email protected]
Company: Clydo

Test Parameters:

{
  bidder: 'clydo,
  params: {
    partnerId: 'fafafa',
    region: 'us'
  }
}

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @cto-clydo

I took a look through the adapter code, and there are a number of areas that should not be needed (as you're using the ortbConverter) or just need another review.

Can you please take a look?

@jsnellbaker
Copy link
Collaborator

@cto-clydo thank you for making the various updates. Are the bid params values in the description a valid set?

When I was attempting to run this adapter in the hello_world.html page, I was seeing the following errors:

Access to fetch at 'https://us.clydo.io/fafafa' from origin 'http://test.localhost:9999' has been blocked by CORS policy: The value of the 'Access-Control-Allow-Origin' header in the response must not be the wildcard '*' when the request's credentials mode is 'include'.Understand this error

POST https://us.clydo.io/fafafa net::ERR_FAILED 204 (No Content)

@cto-clydo
Copy link
Contributor Author

@jsnellbaker thank you for the review, it's mocked parameters in tests, you can use this to test connection

"params": {
    "partnerId": "kXd4kJqGub5tJdQVSVVc",
    "region": "us"
  }

@cto-clydo thank you for making the various updates. Are the bid params values in the description a valid set?

When I was attempting to run this adapter in the hello_world.html page, I was seeing the following errors:

Access to fetch at 'https://us.clydo.io/fafafa' from origin 'http://test.localhost:9999' has been blocked by CORS policy: The value of the 'Access-Control-Allow-Origin' header in the response must not be the wildcard '*' when the request's credentials mode is 'include'.Understand this error

POST https://us.clydo.io/fafafa net::ERR_FAILED 204 (No Content)

@jsnellbaker
Copy link
Collaborator

@cto-clydo thank you for the updated params. I gave them a try but I've been seeing 204 No Content responses from the endpoint.

To clarify here is a copy of the request to the endpoint with its payload. Can you take a look to see if everything appears correct?
https://us.clydo.io/kXd4kJqGub5tJdQVSVVc

{"imp":[{"ext":{"data":{"adserver":{"name":"gam","adslot":"/19968336/header-bid-tag-0"}},"gpid":"/19968336/header-bid-tag-0","clydo":{"partnerId":"kXd4kJqGub5tJdQVSVVc","region":"us"}},"id":"5937d67e-bacb-4547-820e-375a777b90ce","banner":{"topframe":1,"format":[{"w":300,"h":250}]},"secure":1}],"site":{"domain":"test.localhost:9999","publisher":{"domain":"test.localhost:9999"},"page":"http://test.localhost:9999/integrationExamples/gpt/hello_world.html?pbjs_debug=true"},"device":{"w":2560,"h":1440,"dnt":0,"ua":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/142.0.0.0 Safari/537.36","language":"en","ext":{"vpw":2560,"vph":716},"sua":{"source":1,"platform":{"brand":"macOS"},"browsers":[{"brand":"Chromium","version":["142"]},{"brand":"Google Chrome","version":["142"]},{"brand":"Not_A Brand","version":["99"]}],"mobile":0}},"source":{"ext":{}},"id":"82189065-9019-4bed-ab04-f32606879b52","test":0,"tmax":1000}

@cto-clydo
Copy link
Contributor Author

@jsnellbaker We've added some test demand. You can try again with the same payload. Your request is correct

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cto-clydo thank you for making the additional updates to provide a test creative for a delivery test. Confirmed the delivery is working and the ad rendered fine.

LGTM

@jsnellbaker jsnellbaker merged commit 9585e8f into prebid:master Dec 12, 2025
218 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants