Skip to content

Conversation

@joebeachjoebeach
Copy link
Contributor

I noticed while using create-wmr that when passing --eslint, eslint and eslint-config-preact ended up in "dependencies" instead of "devDependencies" in my package.json.

Notes

  • I added eslint-disable comments because the commit hook was blocking me from committing the file with the pre-existing console statements in it. I saw disable comments in other packages so I figured that's appropriate.
  • I haven't been able to manually validate this. Running yarn prepare in the create-wmr package directory hangs and uses up a whole lot of my CPU. And I'm unable to directly execute src/index.js as it uses ES module syntax. Telling node that it's a module results in __dirname is not defined errors, as __dirname isn't available in ES modules' scope.

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2022

🦋 Changeset detected

Latest commit: f9469fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-wmr Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rschristian
Copy link
Member

Running yarn prepare in the create-wmr package directory hangs and uses up a whole lot of my CPU.

Odd. Mind sharing your environment? Don't know what would cause that, and it's seemingly find for me.

But thanks for putting this together! Really appreciate it.

@rschristian rschristian merged commit ab4b512 into preactjs:main Oct 25, 2022
@github-actions github-actions bot mentioned this pull request Oct 25, 2022
@joebeachjoebeach joebeachjoebeach deleted the eslint-save-dev branch November 1, 2022 23:08
@joebeachjoebeach
Copy link
Contributor Author

@rschristian thanks for the quick turnaround!

Mind sharing your environment?

macOS 11.6, and it has the same behavior with node 16.18.0 and 18.11.0. not sure what's causing it, but I figure it's a "me" thing and I'll dig into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants