Skip to content

Conversation

@rschristian
Copy link
Member

@rschristian rschristian commented Aug 18, 2025

Our benchmarks action is failing on PRs opened against v10.x as we're not running the "CI" workflow on push. The "CI" workflow triggers "Build & Test" which uploads assets that future commits will compare against; the merge commits we're making at the moment aren't associated with a workflow run, ergo, the action will fail to download the artifact for comparison.

Edit: Or at least that's what I think is happening. Fingers crossed?

@github-actions
Copy link

📊 Tachometer Benchmark Results

Summary

A summary of the benchmark results will show here once they finish.

Results

The full results of your benchmarks will show here once they finish.

tachometer-reporter-action v2 for CI

@rschristian
Copy link
Member Author

rschristian commented Aug 18, 2025

On a semi-related note, the Tachometer comment will keep appearing for PRs against v10.x, even when it shouldn't, as there's no way at this time to get a reference to the target branch for workflow_run events when the workflow is triggered due to a PR from a fork. To get the reporter at least semi-working, it uses the SHA of the location in which the reporter is running, aka, main, to use as the base ref. This, however, has the effect of always reporting the JS changed as main and v10.x are now divergent so the diff between them is meaningless.

So it'll be a bit noisy and there will be some empty comments like above, but we'll still get reporting when the benches run, which seems preferable to disabling the thing on branches other than main.

I don't know what else to do here besides write a script to start querying GH's API manually which I'm not exactly thrilled about nor enthusiastic to do; feels like there's a really weird gap in the event payload data here. I opened a couple threads on their site-wide discussions repo, we'll see if that goes anywhere I guess.

@rschristian rschristian merged commit 28a56ca into v10.x Aug 18, 2025
6 checks passed
@rschristian rschristian deleted the ci/fix-benchmarks branch August 18, 2025 04:39
@JoviDeCroock JoviDeCroock mentioned this pull request Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants