Skip to content

Conversation

@frontman-git
Copy link
Contributor

@frontman-git frontman-git commented Jun 11, 2025

Resolves #4769

This change ensures that the function returned by forwardRef carries over the original render callback as a .render property. Without this, integrations like DevTools and mobx-react which rely on calling or observing Component.render were unable to track or trigger updates correctly.

@github-actions
Copy link

github-actions bot commented Jun 11, 2025

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +0% (-5.40ms - +4.04ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.08ms - +0.04ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +2% (-1.30ms - +1.73ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -3% - +1% (-0.46ms - +0.17ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +2% (-0.77ms - +1.11ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -4% - +3% (-0.09ms - +0.05ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +1% (-0.26ms - +0.29ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -4% - +2% (-1.17ms - +0.79ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -9% - +3% (-0.56ms - +0.20ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -2% - +3% (-0.02ms - +0.03ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +1% (-0.01ms - +0.01ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local1008.69ms - 1015.62ms-unsure 🔍
-1% - +0%
-5.40ms - +4.04ms
preact-main1009.62ms - 1016.04msunsure 🔍
-0% - +1%
-4.04ms - +5.40ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.19ms - 19.19ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main19.19ms - 19.19msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.46ms - 16.56ms-unsure 🔍
-0% - +0%
-0.08ms - +0.04ms
preact-main16.51ms - 16.55msunsure 🔍
-0% - +0%
-0.04ms - +0.08ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.54ms - 1.55ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.54ms - 1.55msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local70.07ms - 72.39ms-unsure 🔍
-2% - +2%
-1.30ms - +1.73ms
preact-main70.03ms - 71.99msunsure 🔍
-2% - +2%
-1.73ms - +1.30ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local5.86ms - 6.43ms-unsure 🔍
-9% - +3%
-0.56ms - +0.20ms
preact-main6.07ms - 6.58msunsure 🔍
-3% - +9%
-0.20ms - +0.56ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.21ms - 16.60ms-unsure 🔍
-3% - +1%
-0.46ms - +0.17ms
preact-main16.31ms - 16.80msunsure 🔍
-1% - +3%
-0.17ms - +0.46ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.78ms - 3.78ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main3.77ms - 3.78msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms
-
replace1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local60.64ms - 62.01ms-unsure 🔍
-1% - +2%
-0.77ms - +1.11ms
preact-main60.50ms - 61.80msunsure 🔍
-2% - +1%
-1.11ms - +0.77ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.99ms - 2.99ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main2.99ms - 2.99msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local25.28ms - 25.97ms-unsure 🔍
-3% - +0%
-0.86ms - +0.11ms
preact-main25.66ms - 26.34msunsure 🔍
-0% - +3%
-0.11ms - +0.86ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local31.51ms - 33.07ms-unsure 🔍
-3% - +4%
-0.96ms - +1.15ms
preact-main31.49ms - 32.90msunsure 🔍
-4% - +3%
-1.15ms - +0.96ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local28.42ms - 29.54ms-unsure 🔍
-0% - +5%
-0.13ms - +1.38ms
preact-main27.85ms - 28.86msunsure 🔍
-5% - +0%
-1.38ms - +0.13ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local25.45ms - 26.60ms-unsure 🔍
-3% - +3%
-0.67ms - +0.83ms
preact-main25.46ms - 26.42msunsure 🔍
-3% - +3%
-0.83ms - +0.67ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local22.63ms - 23.94ms-unsure 🔍
-4% - +4%
-0.94ms - +1.04ms
preact-main22.50ms - 23.98msunsure 🔍
-4% - +4%
-1.04ms - +0.94ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local20.18ms - 21.07ms-unsure 🔍
-4% - +2%
-0.92ms - +0.42ms
preact-main20.38ms - 21.38msunsure 🔍
-2% - +4%
-0.42ms - +0.92ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #4775
  • Commit: a76dd9b

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.99ms - 2.09ms-unsure 🔍
-4% - +3%
-0.09ms - +0.05ms
preact-main2.00ms - 2.12msunsure 🔍
-3% - +5%
-0.05ms - +0.09ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local0.97ms - 1.00ms-unsure 🔍
-2% - +3%
-0.02ms - +0.03ms
preact-main0.96ms - 0.99msunsure 🔍
-3% - +2%
-0.03ms - +0.02ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local32.74ms - 33.20ms-unsure 🔍
-1% - +1%
-0.26ms - +0.29ms
preact-main32.80ms - 33.11msunsure 🔍
-1% - +1%
-0.29ms - +0.26ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.24ms - 1.26ms-unsure 🔍
-1% - +1%
-0.01ms - +0.01ms
preact-main1.24ms - 1.26msunsure 🔍
-1% - +1%
-0.01ms - +0.01ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local32.26ms - 33.74ms-unsure 🔍
-4% - +2%
-1.17ms - +0.79ms
preact-main32.54ms - 33.83msunsure 🔍
-2% - +4%
-0.79ms - +1.17ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.94ms - 2.94ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main2.93ms - 2.94msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms
-

tachometer-reporter-action v2 for CI

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing this

@marvinhagemeister marvinhagemeister merged commit ba198b7 into preactjs:main Jun 11, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support .render property in the return value of forwardRef

2 participants