Switch test suite to pytest and update CI workflow to support pytest#521
Switch test suite to pytest and update CI workflow to support pytest#521ppizarror merged 6 commits intoppizarror:masterfrom
Conversation
07b1e34 to
da50066
Compare
|
@ppizarror quick question about the CI setup. Right now the repo uses a reusable workflow: Would you prefer:
Just want to align with your preferred direction before I touch anything. |
|
Hi. I will update the workflow, adding a "test_engine": pytest |
|
@ppizarror ok, let me know when it's ready, eventually you could replace: with |
|
Hi @JaskRendix . I've added a "engine" param, so in this case, workflow should be edited with Followed your guidelines, hope it works: ppizarror/workflow-actions@2577eb7 |
|
@ppizarror we need to merge the other PR with the updated |
merged. Lets see how that works. |
e71c546 to
b44de2b
Compare
|
@ppizarror now everything runs. I bumped into failing tests with a segfault in garbage collection caused by pygame cleanup. Disabling GC during tests and running a manual cleanup after each test fixes the issue. |
PR updates the test suite to use pytest. The current CI workflow fails because the reusable workflow runs nose2, which cannot execute pytest tests. The suite uses pytest features such as fixtures, parametrization, and monkeypatch, so nose2 cannot run it. To restore CI compatibility, the reusable workflow needs to support pytest. Possible solutions:
Replace the nose2 command with pytest:
Add an input to select the test runner:
and switch based on that value.
Add an input that allows callers to override the test command.
The test suite passes locally under pytest and requires CI support for pytest to run correctly.