[pull] master from Azure:master#91
Merged
pull[bot] merged 2 commits intopphuchar:masterfrom May 31, 2019
Merged
Conversation
…/power on some cables (#2957) * [device/mellanox/x86_64-mlnx_msn2700-r0/plugins/sfputil.py] purpose and restrictions 1. reading eeprom via ethtool. 2. avoid changing common codes shared by all the manufacture (sonic-platform-common), contrain all the modifications with Mellanox-specific code. current implementation A new class based on SfpUtilBase and a new method _read_eeprom_specific_bytes_via_ethtool have been introduced in order to change the way the eprom DOM data is read. Typically the best practice to do this kind of thing is to contrain the modification within the function which execute reading operations only and keep other stuffs (especially the interface) untouched. However, this can hardly be achieved since the original reading function takes the file object as input parameter to represent the port. It is done by having the file object to point to /var/run/hwmanagement files, which will not be maintained in the future. As a result, a new interface has to be introduced with a port number/name as input parameter in order to get rid of the dependency on the those files: _read_eeprom_specific_bytes_via_ethtool Since the interface changed, all methods that call the interface should also be overwritten in order to call the new interface, including: _read_eeprom_devid get_transceiver_info_dict get_transceiver_dom_info_dict Only interface used to read eeprom DOM has been replaced and the main logic has not been changed except the following mentioned. 1. reading DOM data for sfp port, which is implementioned in get_transceiver_dom_info_dict. In this case a "calibration" should be firstly read from eeprom before other values like temperature, voltage, rx/tx power, can be parsed. However, this has been ignored in the original code, resulting in that the data cann't be parsed. 2. In the original implemention the data area containing the data are read from DOM separatedly in order to avoid read uncessary data and achieve a better performance. Having used ethtool to read DOM data, the performance gap between reading all the area and reading the spot data separatedly has been narrowed to almost zero. To make the code neat and readable, we change the way to read this data. * [sfputil] Returns dict with all data set to N/A for ports without dom support Currently, the way in which dom data is read has been changed from using sysfs to using ethtool. The ethtool returns None for ports without dom support, resulting in None being returned. However, this fails xcvrd to add the TRANSCEIVER_DOM_SENSOR table entry of associated port to CONFIG_DB and then causes SNMP fail. To address this issue a default dict is initialized with all data set to 'N/A' and is returned is the above case. BTW, in the original implementation which sysfs is used to read dom data, even though non-None data is returned for ports without dom support, it does not contain valid data. This can result in wrong data in TRANSCEIVER_DOM_SENSOR table. * [sfputil] removing unnecessary empty lines removing redundent code replacing hardcoding strings/numbers with predefined const variables
pull bot
pushed a commit
that referenced
this pull request
Jun 28, 2020
…te submodules (sonic-net#4852) * src/sonic-platform-common 75698a8...82bbeab (9): > [sfputil] Make SfpUtilHelper.get_physical_to_logical noexcept as in SfpUtilBase (#96) > [sfp_base] Update return value documentation of channel-specific methods (#98) > [sfp] Tweak key names of some transceiver info fields (#97) > fix typo: portconfig.ini to port_config.ini (#94) > [chassis_base] Add platform API support for system LED (#91) > Add PCIe check commad (#64) > [sfputilbase.py] Don't try to print EEPROM sysfs file name if we failed to read from it (#81) > [sfputilbase | sfputilhelper] Add support of platform.json (#72) > [eeprom] Add try-except to catch the IOError (#85) * src/sonic-platform-daemons 0f4fd83...abe115e (2): > [xcvrd] Tweak some transceiver info key names (#62) > [psud][thermalctld] Always get fan/PSU LED status from platform API to avoid status inconsistencies (#59) * src/sonic-utilities fd7781b...16a33f2 (9): > [config] Fix syntax error (#966) > [config] Fix indentation level in _get_disabled_services_list() (#965) > a4e64d1 [sonic_installer] Refactor sonic_installer code (#953) > 90efd62 [Show | Command Reference] Add Port breakout Show Command (#859) > [sfpshow][mock_state_db] Tweak key names of some transceiver info fields (#958) > [show] Add missing verbose option to "show line" (#961) > [filter-fdb] Check VLAN Presence When Filter FDB (#957) > [master]fix sonic-net#4716 show ipv6 interfaces neighbor_ip is N/A issue (#948) > Fix for command. show interface transceiver eeprom -d Ethernet (#955) Note: sonic-utilities update fixes sonic-net#4716
pull bot
pushed a commit
that referenced
this pull request
Sep 11, 2020
- sonic-net/sonic-platform-daemons@1893c40 - Fix the xcvrd theowing error on sfprecover function on getKeys() not valid. - sonic-net/sonic-platform-daemons@65fa443 - Merge pull request #90 from abdosi/multiasic-fix - sonic-net/sonic-platform-daemons@7f812c9 - [xcvrd] Don't log unnecessary messages upon empty transceiver change event (#53) - sonic-net/sonic-platform-daemons@0969202 - Fix pcied daemon failure (#91) Signed-off-by: Petro Bratash <petrox.bratash@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]