Add SHA256 checksum verification and robust URL validation for image#824
Add SHA256 checksum verification and robust URL validation for image#824tsj-30 wants to merge 3 commits intoppc64le-cloud:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tsj-30 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @tsj-30! It looks like this is your first PR to ppc64le-cloud/pvsadm 🎉 |
|
Hi @tsj-30. Thanks for your PR. I'm waiting for a ppc64le-cloud member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@sudeeshjohn anyone using this script? may be need your reviewing this script |
|
I would suggest to add the checksum validation in getImage function as well pvsadm/cmd/image/qcow2ova/get-image.go Line 34 in 1936990 |
|
/ok-to-test |
What this PR does / why we need it:
This PR adds SHA-256 checksum verification and robust URL validation for image downloads in the convert-upload-images-powervs script.
It ensures that corrupted or partially downloaded .qcow2 images (caused by unescaped characters like & in URLs) are detected and the script terminates safely instead of continuing with invalid data.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #92
Special notes for your reviewer:
**Output/Demonstration