Remove orphaned network policy resource #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlangfeld
reviewed
Feb 21, 2024
benlangfeld
reviewed
Feb 21, 2024
Co-authored-by: Ben Langfeld <[email protected]>
Co-authored-by: Ben Langfeld <[email protected]>
indiebrain
reviewed
Feb 21, 2024
Co-authored-by: Aaron Kuehler <[email protected]>
Co-authored-by: Aaron Kuehler <[email protected]>
benlangfeld
changed the title
Merged
indiebrain
added a commit
that referenced
this pull request
Feb 26, 2024
Prepare the repository for tagging / release of version 2.1.0. Note, this release contains a [fix](#49) for #48 - hence the minor version upgrade. References ---------- - https://semver.org/#what-do-i-do-if-i-accidentally-release-a-backward-incompatible-change-as-a-minor-version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #48
This PR aims to address an issue introduced in release 2.0.1, where the logic for generating network policy resources by the operator was changed. From version 2.0.1 onwards, the operator no longer generates network policies for Redis but failed to remove existing policies generated prior to this version. This PR introduces a check and removal process for that leftover network policiy.