Skip to content

Fix floating point exception#54

Merged
posva merged 1 commit into
posva:masterfrom
boretom:fix/fp-exception
Jul 31, 2020
Merged

Fix floating point exception#54
posva merged 1 commit into
posva:masterfrom
boretom:fix/fp-exception

Conversation

@boretom
Copy link
Copy Markdown
Contributor

@boretom boretom commented Jul 29, 2020

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Ok, I'm pretty sure I got it this time.

Btw: The floating point will happen with all images, it just depends on the -H value. E.g. catimg -H 80 test-images/mewtwo-front.png also triggers it.

Btw2: I started with a branch where I added simple CMake tests feature/add-simple-tests just in case you're bored. It merged with every branch. Two lines are added to the end of CMakeLists.txt and a new directory test. One can run it by calline ctest after make or make test

Copy link
Copy Markdown
Owner

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@posva posva merged commit 5e096fa into posva:master Jul 31, 2020
@posva
Copy link
Copy Markdown
Owner

posva commented Jul 31, 2020

What test did you add? A visual one?

@boretom boretom deleted the fix/fp-exception branch September 18, 2020 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants