breaking(): remove legacy code and introduce browser entry #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricksevat
commented
Nov 4, 2025
| (typeof window === 'undefined' ? it : it.skip)('should return input value on invalid domain', function () { | ||
| expect(encoder.encodeHost('xn:')).to.equal('xn:'); | ||
| expect(encoder.encodeHost('example#com')).to.equal('example#com'); | ||
| // expect(encoder.encodeHost('example#com')).to.equal('example#com'); |
Collaborator
Author
There was a problem hiding this comment.
In newer Node versions (I used Node 22), this breaks
patricksevat
commented
Nov 4, 2025
| 'HTTP://example.com', | ||
| 'http://xn--48jwgn17gdel797d.com', | ||
| 'http://xn--iñvalid.com', | ||
| // 'http://xn--iñvalid.com', |
Collaborator
Author
There was a problem hiding this comment.
In newer Node versions, this breaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation has several imports which are not browser friendly:
require('url')in encoder/indexrequire('url')in legacyThis PR fixes those by providing a browser entrypoint which is mostly based on the browser's
URLapi: https://developer.mozilla.org/docs/Web/API/URL while trying to keep the api and results the same.That said, there are some breaking changes and behavioral differences:
BREAKING
Behavorial changes, only applicable to the BROWSER ENTRYPOINT
.encodeQueryStringwith multi values behaves differently:'q1=𝌆й&q1=你ス&q2='(note the double q1 param)'q1=𝌆й,你ス&q2='(single, comma-separated q1 param)toNodeUrl('xn--iñvalid.com')host: 'xn--iñvalid.com',host: '-xn--xn--ivalid-x9a.com'