Feature/omit schema #892
Closed
Feature/omit schema #892
+177
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
integration test code coverage
Coverage Breakdown • (19%)
|
unit test code coverage
Coverage Breakdown • (89%)
|
barshan23
reviewed
Oct 31, 2025
libV2/schemaUtils.js
Outdated
| // Objects: emit all keys except those that are schema definition keys | ||
| const schemaKeys = Object.keys(_.get(param, 'schema', {})); | ||
| _.forEach(paramValue, (value, key) => { | ||
| if (schemaKeys.includes(key)) { |
There was a problem hiding this comment.
In case there are properties in the query param that matches the schema, with this current change those properties will not show up in the collection.
Check out the screenshot
The schema contains type and minimum but since the schema also has type defined. The generated request only contains minimum and type was omitted from the request query param.
|
Closing this PR as this needs to be reworked. Will be raising a separate PR for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent parameter.schema keys (e.g., deprecated) from becoming query params
AB-1584 https://postmanlabs.atlassian.net/browse/AB-1584