Skip to content

Conversation

@jatin3893
Copy link
Collaborator

@jatin3893 jatin3893 commented Aug 22, 2025

  1. The generated strings are of random length -> Hence making it more specific to ensure it doesn't show random keywords
  2. The regex used for generating UUIDs contained urn:uuid: in the prefix which is not required for UUID. Hence removing the same.

Test Scenarios after Integrating with postman-app:

  1. Generated 100 UUIDs -> All are consistent without the urn:uuid prefix
image
  1. Generated 100 normal strings -> All show "string" in the generated example
Screenshot 2025-08-25 at 3 00 55 PM

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2025

integration test code coverage

Lines Statements Branches Functions
Coverage: 19%
19.38% (2040/10525) 13.55% (993/7327) 20.06% (235/1171)
Coverage Breakdown • (19%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files19.3813.5520.0619.67 
report-only-changed-files is enabled. No files were changed in this commit :)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2025

unit test code coverage

Lines Statements Branches Functions
Coverage: 89%
89.22% (5728/6420) 80.71% (3725/4615) 93.92% (850/905)
Coverage Breakdown • (89%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files89.2280.7193.9289.34 
report-only-changed-files is enabled. No files were changed in this commit :)

@jatin3893 jatin3893 requested review from barshan23 and Copilot August 22, 2025 15:29

This comment was marked as outdated.

@jatin3893 jatin3893 requested a review from Copilot August 25, 2025 07:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the deterministic behavior of faker data generation by ensuring consistent string lengths and correcting UUID format generation.

  • Modifies the default minimum string length from 0 to 6 to prevent truncated string outputs
  • Removes the unnecessary urn:uuid: prefix from UUID regex pattern to generate clean UUID format
Comments suppressed due to low confidence (1)

assets/json-schema-faker.js:1

  • The hardcoded minimum length of 6 is a magic number. Consider defining it as a named constant (e.g., MIN_STRING_LENGTH = 6) to improve code readability and maintainability.
/* eslint-disable */

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@barshan23 barshan23 merged commit 4dc5f89 into develop Aug 25, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants