Skip to content

Conversation

@ludofischer
Copy link
Contributor

@ludofischer ludofischer commented Nov 29, 2020

This pull request drops node_modules from 592K to 364K (with yarn install --prod). Without it, this package installs colorette, but also chalk, since log-symbols depends on it.
I've kept log-symbols in the tests as a sanity check.

* Inline the warning symbol to drop prod dependency on log-symbols,
  which depends on chalk.
@ai ai merged commit 791276d into postcss:master Nov 29, 2020
@ai
Copy link
Member

ai commented Nov 29, 2020

My favourite type of PR 😻

@ai
Copy link
Member

ai commented Nov 29, 2020

I will release it a few hours later

@ai
Copy link
Member

ai commented Nov 30, 2020

Released in 7.0.2

@ludofischer ludofischer deleted the no-chalk branch December 1, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants