Skip to content

feat(layout_columns): Use sm as the default col_widths breakpoint #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gadenbuie merged 4 commits into from
Mar 19, 2024
Merged

feat(layout_columns): Use sm as the default col_widths breakpoint #1222

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9decc9c
feat(layout_columns): Make `sm` the default breakpoint
gadenbuie Mar 16, 2024
7addd87
fix(layout_columns): `xs` for `row_heights` does require the class
gadenbuie Mar 17, 2024
d61ad57
chore: Update bslib and shiny
gadenbuie Mar 19, 2024
56a72f2
docs: update changelog
gadenbuie Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions shiny/ui/_layout_columns.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ def as_col_spec(
return None

if not isinstance(col_widths, Dict):
return {"md": validate_col_width(col_widths, n_kids, "md")}
return {"sm": validate_col_width(col_widths, n_kids, "sm")}

ret: BreakpointsOptional[int] = {}
col_widths_items = cast(BreakpointsSoft[int], col_widths).items()
Expand Down Expand Up @@ -259,12 +259,8 @@ def row_heights_attrs(
# Remove any None values from x
x_complete = {k: v for k, v in x.items() if v is not None}

# We use classes to activate CSS variables at the right breakpoints. Note: Mobile
# row height is derived from xs or defaults to auto in the CSS, so we don't need the
# class to activate it
classes = [
f"bslib-grid--row-heights--{brk}" for brk in x_complete.keys() if brk != "xs"
]
# We use classes to activate CSS variables at the right breakpoints.
classes = [f"bslib-grid--row-heights--{brk}" for brk in x_complete.keys()]

# Create CSS variables, treating numeric values as fractional units, passing strings
css_vars: Dict[str, str] = {}
Expand Down