Only apply consecutive changes when updating document states #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses posit-dev/positron#681
This really shot up to Private Alpha priority for me because it was happening all the time, especially when typing
options()in the console for some reason.This is really a follow up to this commit posit-dev/positron@6c0f1a9, which is related to posit-dev/positron#340.
In that commit, we handle out of order changes by storing them until we see the next consecutive change, but we could run into a scenario like this:
In other words, once we hit the next consecutive change we just unload all the changes without checking that they are also consecutive.
This PR fixes this by only applying as many consecutive changes as possible, and then we re-push the remaining changes that we can't apply right now as
pendingagain.Here is me catching the problem with some extra logging
And here it is now with the fix