Wait for pod evictions when draining, up to 60 seconds. #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Is there any appetite for this change? |
craigcabrey
added a commit
to craigcabrey/fleetlock
that referenced
this pull request
Apr 5, 2025
github-actions bot
pushed a commit
to craigcabrey/fleetlock
that referenced
this pull request
May 18, 2025
github-actions bot
pushed a commit
to craigcabrey/fleetlock
that referenced
this pull request
May 25, 2025
|
This would solve a huge headache of ours as fleetlock shuts down our nodes before our database pods gracefully shuts down, forcing an ugly failover. @dghubble, sorry for the ping but is this feature something that can be considered? |
Author
|
FWIW we've been running with this change in production for almost a year now |
|
Thanks @vadimberezniker, we made a fork with the commits from this PR and are very happy with the results 🎉 It really should be merged in the official provider but a fix is a fix I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The drainer attempts to evict pods but doesn't wait at all (?) for evictions to complete which does not allow time for graceful termination of pods that need it.